-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution Inga Tkachuk #1884
base: main
Are you sure you want to change the base?
Solution Inga Tkachuk #1884
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
Let's improve your page
- Add the horizontal padding for the content
- Add a favicon on the page
- Where is the phone icon?
- Add transition when this menu appears on the page and remove scroll when menu is open
- Where are the second images?
- The user cannot be able to change size of the textarea field
@volodymyr-soltys97 Thanks for the review! I've resolved all the issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please review your demo link again and compare it with the Figma design; they should look very similar. If you're facing any issues with the implementation, don't hesitate to ask for help in the chat
Hi, there is widespread comment, please tell me what you actually mean with examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@etojeDenys Wow, thanks a lot for the review, it makes me better) I fixed all the issues you pointed that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job.
Needs some improvements.
- suggest to limit max content width. 1440px will be good (on wide screen now some images visible on full screen)
- add paddings for inputs
- add cursor pointer for all interactive elements.
- add transition for all elements with hover effect
- click on phone should start a call (check in header)
- click on address should open google maps in new tab.
- nothing happened after click on submit button in form.
pay attention on checklist, check and fix points, which need it.
@VitaliyBondarenko1982 Thank you for review; I hope I understand you correctly and did the right fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VitaliyBondarenko1982 I fixed this "also will be better scale only images in the recommended section.", but this comment "content should be centered horizontally." a bit confused me I already have horizontal centered in my styles, maybe you can a little bit explain? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, could you create the thread in the chat and ping me there, let's discuss there how to limit and center the block
https://idwil8.github.io/layout_landing-page/