-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #1887
base: main
Are you sure you want to change the base?
add task solution #1887
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 👍
Let's improve your page
- You need to show additional phone number when hovering this icon
- Add the topical title and favicon on the page
- Remove scroll when the menu is open
- You need to change image for header, without red border
- Add hover effects for images
- Fix gap between these elements, check it on the design
- Make all these fields are required before sending
- Add cursor pointer for all clickable elements
- All these elements must be links and add hover effects here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done!
To improve:
- Change title of the page to
B&O
. Title should be actual
- Fix styles and position for the phone number, check it on the design. Also, you need to make a call when user clicks here
- The images shouldn't overlap each other when hovering
- Add hover effects for these blocks
-
After submit the form don't refresh page and scroll to top, you need only reset form fields
-
Add the topical address on google maps for this link
- This element should be link with
mailto:
- The header looks strange on the mobile, fix it
- Also, you need to hide the additional phone number on the mobile and tablet versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
-DEMO LINK