-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #5078
base: master
Are you sure you want to change the base?
Develop #5078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed before we can approve the pull request. Specifically, the task requires the separation of BEM blocks into individual files, the use of SCSS variables in a separate file, and ensuring the correct file structure for images. Additionally, there are several typographical errors in class names that need to be corrected to ensure consistency and functionality. Please make these changes, and feel free to reach out if you need any help! Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
src/index.html
Outdated
</h3> | ||
<p class="product__code">Product code: 195434</p> | ||
</div> | ||
<div class="rewiews card__rewie"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the class name 'rewiews'. It should be 'reviews' to maintain consistency and avoid potential issues with styling or JavaScript functionality.
src/index.html
Outdated
<p class="product__code">Product code: 195434</p> | ||
</div> | ||
<div class="rewiews card__rewie"> | ||
<div class="stars stars--4 rewiews__stars"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the class name 'rewiews__stars'. It should be 'reviews__stars'.
src/index.html
Outdated
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
<div class="rewiews__count">Reviews: 5</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the class name 'rewiews__count'. It should be 'reviews__count'.
src/index.html
Outdated
<div class="rewiews__count">Reviews: 5</div> | ||
</div> | ||
<div class="price card__price"> | ||
<p class="price__titel">Price:</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the class name 'price__titel'. It should be 'price__title'.
src/styles/index.scss
Outdated
&__prod { | ||
margin-bottom: 16px; | ||
} | ||
&__rewie { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the class name '&__rewie'. It should be '&__review' to match the corrected class name in the HTML file.
src/styles/index.scss
Outdated
display: flex; | ||
justify-content: space-between; | ||
|
||
&__titel { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the class name '&__titel'. It should be '&__title' to match the corrected class name in the HTML file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on making progress with your project! 🎉 While there are some typographical errors in class names such as rewie
instead of review
, titel
instead of title
, and others, your overall structure and use of SCSS are well-executed. Please address these errors to ensure consistency and functionality. Remember, attention to detail is crucial in coding, and fixing these will help avoid potential issues. Keep up the good work and continue learning from these experiences!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/index.html
Outdated
</h3> | ||
<p class="product__code">Product code: 195434</p> | ||
</div> | ||
<div class="rewiews card__rewie"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typographical error in the class name 'rewiews'. It should be 'reviews' to maintain consistency and avoid potential styling issues.
src/index.html
Outdated
<p class="product__code">Product code: 195434</p> | ||
</div> | ||
<div class="rewiews card__rewie"> | ||
<div class="stars stars--4 rewiews__stars"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class name 'rewiews__stars' contains a typographical error. It should be 'reviews__stars'.
src/index.html
Outdated
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
<div class="rewiews__count">Reviews: 5</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class name 'rewiews__count' contains a typographical error. It should be 'reviews__count'.
src/index.html
Outdated
<div class="rewiews__count">Reviews: 5</div> | ||
</div> | ||
<div class="price card__price"> | ||
<p class="price__titel">Price:</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typographical error in the class name 'price__titel'. It should be 'price__title'.
src/styles/utils/bem-block.scss
Outdated
&__prod { | ||
margin-bottom: 16px; | ||
} | ||
&__rewie { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typographical error in the class name 'rewie'. It should be 'review' to maintain consistency with the HTML and avoid potential styling issues.
src/styles/utils/bem-block.scss
Outdated
} | ||
} | ||
|
||
.rewiews { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class name 'rewiews' contains a typographical error. It should be 'reviews'.
src/styles/utils/bem-block.scss
Outdated
display: flex; | ||
justify-content: space-between; | ||
|
||
&__titel { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typographical error in the class name 'titel'. It should be 'title'.
DEMO LINK
TEST REPORT LINK
there 2 BEM blocks
card
andstars
each in their own fileSCSS Nesting is used for
elements
,modifiers
andpseudo-classes
SCSS Variables are used for main values and placed in a separate file
all
stars--N
modifiers work as expected (Highlight firstN
stars)Code follows all the [Code Style Rules ❗️]