Bulls and Cows game #196
Open
Bulls and Cows game #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anna-Tkachenko
requested changes
Jul 26, 2023
src/app.js
Outdated
|
|
||
| const { generateNumber } = require('./numGenerator'); | ||
| const { bullsAndCows } = require('./bullsAndCows'); | ||
| const { inputFunc } = require('./inputOutput'); |
There was a problem hiding this comment.
check function name, let's not make it shortened as it affects in bad way on the code readability
src/app.js
Outdated
|
|
||
| const result = bullsAndCows(secretNumber, guess); | ||
|
|
||
| !result.bulls === 4 && game(); |
There was a problem hiding this comment.
This code isn't readable
It's the statement for checking if you should call game one more time, right? Let's write it with if / else statement
src/app.js
Outdated
| }; | ||
|
|
||
| function isValidGuess(guess) { | ||
| return /^\d{4}$/.test(guess) && new Set(guess).size === 4; |
There was a problem hiding this comment.
Let's create the variable for the template string
BudnikOleksii
approved these changes
Aug 15, 2024
| @@ -9,7 +9,14 @@ | |||
| * @return {boolean} - True if the user input is valid, false otherwise | |||
| */ | |||
| function checkIsValidUserInput(userInput) { | |||
| /* Write your code here */ | |||
| const VALID_GUESS_PATTERN = /^\d{4}$/; | |||
There was a problem hiding this comment.
Move constants outside the function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.