Solution

[Hladkyi03]

No description provided.

[DarkMistyRoom]

Good job! Let's improve it a bit

[DarkMistyRoom]

why don't you use increment here?

[DarkMistyRoom]

Suggested change

	let randomNumber = '';
	const previousNumbers = [];
	for (let i = 0; i < 4;) {
	const randomNum = Math.floor(Math.random() * 10);
	if (randomNum === 0 && i === 0) {
	continue;
	}
	if (previousNumbers.includes(randomNum)) {
	continue;
	}
	previousNumbers.push(randomNum);
	randomNumber += randomNum.toString();
	i++;
	}
	return +randomNumber;
	let res = '';
	const numbers = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9];
	for (let i = 0; i < 4; i++) {
	const index = Math.floor(Math.random() * (10 - i));
	res += numbers.splice(index, 1)[0];
	}
	return res;

[DarkMistyRoom]

would be great to specify what the user has done wrong. You can do it inside the validation function

[DarkMistyRoom]

no need to use additional resolve here

[Hladkyi03]

Your code for generating number dont pass 2 tests, so i didnt use it. Improved validation function, now it gives certain information whats wrong. Also changed a bit asdForNumber function and i need both resolves, if i remove one of them the program will not work with wrong input

[anastasiiavorobiova]

The previous mentor's comments were not fixed

[Hladkyi03]

What didnt fixed? I wrote a message, where explained all details, if u provide a comment u should describe what i need to do

[vadiimvooo]

Please check comments and fix the code.

[vadiimvooo]

You should remove redundant then chain

[vadiimvooo]

This block can be modified in the next way

Suggested change

	let randomNumber = '';
	const previousNumbers = [];
	for (let i = 0; i < 4;) {
	const randomNum = Math.floor(Math.random() * 10);
	if (randomNum === 0 && i === 0) {
	continue;
	}
	if (previousNumbers.includes(randomNum)) {
	continue;
	}
	previousNumbers.push(randomNum);
	randomNumber += randomNum.toString();
	i++;
	}
	return +randomNumber;
	function generateRandomNumber() {
	const secretCode = Array.from({ length: 4 }, (el) => 'x');
	for (let i = 0; i < secretCode.length; i++) {
	secretCode[i] = assignRandomNumber(secretCode);
	}
	return Number(secretCode.join(''));
	}
	const assignRandomNumber = (secretCode) => {
	const number = Math.floor(Math.random() * 9 + 1);
	if (secretCode.includes(number)) {
	return assignRandomNumber(secretCode);
	}
	return number;
	};

[maxim2310]

Well done