Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game solution #360

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Oleksii-Mishchenko
Copy link

No description provided.

Copy link

@DarkMistyRoom DarkMistyRoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Let's improve it a bit

src/modules/generateRandomNumber.js Outdated Show resolved Hide resolved
src/modules/getBullsAndCows.js Outdated Show resolved Hide resolved
Comment on lines +27 to +29
} else {
play('Please, try again!\n');
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to reach this case?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every time the entered number's validation fails. E.g. 0123 or 9999 etc.

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants