-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #439
base: master
Are you sure you want to change the base?
Solution #439
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
name: Test | ||
|
||
on: | ||
pull_request: | ||
branches: [ master ] | ||
|
||
jobs: | ||
build: | ||
|
||
runs-on: ubuntu-latest | ||
|
||
strategy: | ||
matrix: | ||
node-version: [20.x] | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
- run: npm install | ||
- run: npm test |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,27 @@ | ||
'use strict'; | ||
|
||
// Write your code here | ||
const readline = require('node:readline'); | ||
const { generateRandomNumber } = require('../src/modules/generateRandomNumber'); | ||
const { | ||
checkIsValidUserInput, | ||
} = require('../src/modules/checkIsValidUserInput'); | ||
const { getBullsAndCows } = require('../src/modules/getBullsAndCows'); | ||
|
||
const rl = readline.createInterface({ | ||
input: process.stdin, | ||
output: process.stdout, | ||
}); | ||
|
||
const generatedNumber = generateRandomNumber(); | ||
|
||
rl.question('Enter your number: ', (userInput) => { | ||
if (checkIsValidUserInput(userInput)) { | ||
// eslint-disable-next-line no-console | ||
console.log(getBullsAndCows(userInput, generatedNumber)); | ||
} else { | ||
// eslint-disable-next-line no-console | ||
console.log(`Your number is not valid`); | ||
} | ||
rl.close(); | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,13 @@ | |
* @return {number} A random 4-digit number | ||
*/ | ||
function generateRandomNumber() { | ||
/* Write your code here */ | ||
const randomNumber = Math.floor(Math.random() * (10000 - 1) + 1); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The current logic can generate numbers with fewer than 4 digits and numbers starting with 0. Consider adjusting the range to ensure the generated number is a 4-digit number that does not start with 0. |
||
|
||
if (new Set(randomNumber.toString()).size !== 4) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The check for duplicate digits is correct, but ensure that the generated number is always 4 digits long and does not start with 0. |
||
return generateRandomNumber(); | ||
} else { | ||
return randomNumber; | ||
} | ||
} | ||
|
||
module.exports = { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
userInput
is currently passed as a string togetBullsAndCows
, which expects numeric inputs. Consider convertinguserInput
to a number before passing it to the function.