new sol #148
new sol #148
Conversation
src/app.js
Outdated
| throw new Error(err); | ||
| } | ||
|
|
||
| fs.rename(sourceAbsolutePath, finalDestination); |
There was a problem hiding this comment.
fs.rename is an asynchronous operation and needs to be awaited, or else errors may go unhandled and operations may not complete in the expected order.
src/app.js
Outdated
|
|
||
| fs.rename(sourceAbsolutePath, finalDestination); | ||
| } catch (err) { | ||
| throw new Error(err); |
There was a problem hiding this comment.
You are throwing a new error but not adding any additional context. Consider adding a custom error message to provide more information about what went wrong.
src/app.js
Outdated
| try { | ||
| await fs.access(destinationDirectory); | ||
| } catch (err) { | ||
| throw new Error(err); |
There was a problem hiding this comment.
You are throwing a new error but not adding any additional context. Consider adding a custom error message to provide more information about what went wrong.
src/app.js
Outdated
| try { | ||
| await fs.access(destinationDirectory); | ||
| } catch (err) { | ||
| throw new Error(`Destination directory does not exist: ${destinationDirectory}`); | ||
| } |
There was a problem hiding this comment.
consider avoiding try catch nesting
src/app.js
Outdated
| const destinationAbsolutePath = path.resolve(destination); | ||
|
|
||
| try { | ||
| if (!(await fileExists(sourceAbsolutePath))) { |
There was a problem hiding this comment.
seems like fileExists function is redundant
| if (!(await fileExists(sourceAbsolutePath))) { | |
| if (!(await fs.access(filePath))) { |
src/app.js
Outdated
| const fs = require('fs').promises; | ||
| const path = require('path'); | ||
|
|
||
| const fileExists = async (filePath) => { |
There was a problem hiding this comment.
This function is not used anywhere, so please remove it
No description provided.