Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #153

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

solution #153

wants to merge 2 commits into from

Conversation

Vo7kov
Copy link

@Vo7kov Vo7kov commented Jan 4, 2024

No description provided.

Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, but lets make some improvement

const path = require('path');

// eslint-disable-next-line no-shadow
const moveFile = (currentPath, newPath) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont check if current path are passed and exists and dont handle this error

@Vo7kov Vo7kov requested a review from maxim2310 January 4, 2024 18:32
Copy link

@loralevitska loralevitska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants