Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #187

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #187

wants to merge 2 commits into from

Conversation

PodvAx
Copy link

@PodvAx PodvAx commented Apr 10, 2024

No description provided.

Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. To pass the tests just fix the comment.

src/app.js Outdated
const sourceDir = path.dirname(source);

try {
await fs.access(destinationDir, fs.constants.F_OK);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
await fs.access(destinationDir, fs.constants.F_OK);
await fs.access(destinationDir);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to provide second argument as it's default one and it will be used if nothing was provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants