Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #249

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #249

wants to merge 2 commits into from

Conversation

mykyta01
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


It looks like there's a small issue with the code that needs to be addressed before we can approve it. The dest variable is not declared, which will cause a runtime error. Please declare it using let or const to ensure the code runs smoothly. Once that's fixed, your solution should be good to go! 😊 Keep up the great work, and don't hesitate to reach out if you need any help.

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

src/app.js Outdated
function moveFile() {
const [from, to] = process.argv.slice(2);

const dest =

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dest variable is not declared. You need to declare it using let or const before assigning a value to it.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: 7]

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the function to move a file, similar to the Linux mv command! 🎉 Your code meets the task requirements and constraints, and it correctly handles file movement and error checking. However, there is a critical issue that needs your attention: the destination variable is not properly declared, which could lead to a runtime error. Please ensure that you declare the destination variable using let or const before using it.

Addressing this issue will help you avoid similar problems in the future. Remember, learning from these experiences is key to improving your coding skills. Keep up the good work and continue to refine your code! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

function moveFile() {
const [from, to] = process.argv.slice(2);

const destination =

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The destination variable is not declared. You need to declare it using let or const before assigning a value to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants