Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1469

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,20 @@


def cache(func: Callable) -> Callable:
# Write your code here
pass
cache_storage = {}

def wrapper(*args, **kwargs) -> Callable:
if any(isinstance(arg, (list, dict, set)) for arg in args):
raise ValueError("All arguments must be immutable")
Comment on lines +8 to +9
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check for immutability only covers the positional arguments (args). You should also check the keyword arguments (kwargs) to ensure they are immutable. Consider iterating over kwargs.values() as well.

key = (func, args, frozenset(kwargs.items()))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using frozenset to convert kwargs.items() into an immutable type is correct, but ensure that all values in kwargs are hashable. If any value is a mutable type, it will raise an error.


if key in cache_storage.keys():
print("Getting from cache")
return cache_storage[key]
else:
print("Calculating new result")
result = func(*args, **kwargs)
cache_storage[key] = result
return result

return wrapper
Loading