Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Solution' #1762

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

'Solution' #1762

wants to merge 1 commit into from

Conversation

Bogdannna7
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Car and CarWashStation classes! 🎉 The code meets the task requirements and constraints, with only a minor issue in the rate_service method. The calculation of the new average rating has an extra division that needs to be corrected. Keep up the good work, and consider fixing this small issue to ensure accurate ratings in the future. Happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +37 to +39
self.average_rating = round((self.average_rating
* self.count_of_ratings + rate)
/ (self.count_of_ratings + 1), 1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an error in the calculation of the new average rating. The expression (self.average_rating * self.count_of_ratings + rate) / (self.count_of_ratings + 1) is correct for calculating the new average. However, the extra division by / before (self.count_of_ratings + 1) is incorrect and should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants