-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1_failed #1763
base: master
Are you sure you want to change the base?
1_failed #1763
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! 😊 While your code meets most of the task requirements, there are a few critical issues that need to be addressed before we can approve the pull request. Specifically, the calculate_washing_price
and wash_single_car
methods are using the incorrect parameter type (str
instead of Car
), which impacts the functionality of the code. Additionally, assigning self.car = car
is unnecessary and could lead to confusion. Please make these adjustments to ensure your code functions as intended. Once these changes are made, your solution will be in great shape! Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
class CarWashStation: | ||
# write your code here | ||
pass | ||
def calculate_washing_price(self, car: str): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter car
should be of type Car
, not str
. This method is supposed to calculate the washing price for a Car
object.
# write your code here | ||
pass | ||
def calculate_washing_price(self, car: str): | ||
self.car = car |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assigning self.car = car
is unnecessary and incorrect here. You should directly use the car
parameter in the calculations.
(self.average_rating / self.distance_from_city_center)) | ||
return wash_cost | ||
|
||
def wash_single_car(self, car: str): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter car
should be of type Car
, not str
. This method is supposed to wash a Car
object.
No description provided.