Develop #1995
Closed
Develop #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Great job on meeting the task requirements! 🎉 The code correctly categorizes variables into mutable and immutable types. Although there was a minor note about the collection_of_coins variable, it doesn't impact the core functionality. Keep up the good work, and consider the feedback for future improvements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| # write your code here | ||
| sorted_variables = { | ||
| "mutable" : ["my_favourite_films", "marks", "collection_of_coins"], |
There was a problem hiding this comment.
The collection_of_coins variable is categorized as mutable, but sets in Python are actually mutable. Consider moving collection_of_coins to the 'immutable' category if you intended to categorize it as such.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.