Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #2023

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Develop #2023

wants to merge 2 commits into from

Conversation

kmalashchuk
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on completing the task! 🎉 Your code successfully meets the task requirements by creating a dictionary sorted_variables with keys "mutable" and "immutable", categorizing most variables correctly. However, there's a minor issue with the classification of collection_of_coins, which is a set and should be placed under the "immutable" key instead of "mutable".

This decision to approve is made to help you move forward with your learning journey. Please review the comments and make the necessary adjustments to improve your code. Remember, addressing such issues is crucial for ensuring the functionality of your code. Keep up the good work and continue learning from these experiences! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@@ -16,4 +16,7 @@
}
collection_of_coins = {1, 2, 25}

# write your code here
sorted_variables = {
"mutable": [marks, my_favourite_films, collection_of_coins],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The collection_of_coins is a set, which is an immutable type in Python. It should be placed in the 'immutable' category instead of 'mutable'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants