-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rda_task_1_create_database solution #59
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on meeting the task requirements! 🎉 The SQL script effectively creates the database and tables with the necessary relationships and constraints. While there are a few minor improvements suggested, such as removing the unnecessary Date
column in OrderItems
, adding a UNIQUE
constraint to the Email
field in Customers
, and changing the Price
column to DECIMAL
, these do not impact the core functionality. Keep up the good work and consider these enhancements for future projects! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
ID INT AUTO_INCREMENT, | ||
Name VARCHAR(50), | ||
Description VARCHAR(100), | ||
Price INT, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider changing the Price
column type to DECIMAL
to handle fractional prices, which are common in product pricing.
ID INT AUTO_INCREMENT, | ||
FirstName VARCHAR(50), | ||
LastName VARCHAR(50), | ||
Email VARCHAR(50), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's recommended to add a UNIQUE
constraint to the Email
column to ensure that each customer has a unique email address.
ID INT AUTO_INCREMENT, | ||
OrderID INT NULL, | ||
ProductID INT NULL, | ||
Date DATE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Date
column in the OrderItems
table seems unnecessary. Consider removing it unless there is a specific reason to track dates at the item level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT!
No description provided.