Develop #1579
Open
Develop #1579
+635
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-soltys97
suggested changes
Jan 3, 2025
There was a problem hiding this comment.
Good job 👍
Let's improve your code
-
It is bad practice to write all logic in one component, you need to separate the logic into different components, for example
Header, Footer, TodoItem, TodoList -
The edit mode looks strange, you need to fix styles
- Empty todo should be deleted
src/App.tsx
Outdated
| setChangeTodoId(todoItem.id); | ||
| }; | ||
|
|
||
| const ClearCompleted = () => { |
There was a problem hiding this comment.
Suggested change
| const ClearCompleted = () => { | |
| const clearCompleted = () => { |
There was a problem hiding this comment.
The edit mode looks strange, you need to fix styles - не знаю як це зробити, підскажіть будь-ласка, витратив купу часу і так і не зрозумів, чому стилі не спрацьовують
src/App.tsx
Outdated
| <header className="todoapp__header"> | ||
| <button | ||
| type="button" | ||
| // className="todoapp__toggle-all active" |
There was a problem hiding this comment.
Remove all comments
Suggested change
| // className="todoapp__toggle-all active" |
src/App.tsx
Outdated
| <button | ||
| type="button" | ||
| // className="todoapp__toggle-all active" | ||
| className={`todoapp__toggle-all ${allCompleted ? 'active' : ''}`} |
There was a problem hiding this comment.
Use the classnames library for add classes with condition, fix it everywhere
anastasiiavorobiova
suggested changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK