Develop #1021
Open
Develop #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GUSILLUS
suggested changes
Jul 9, 2024
src/App.tsx
Outdated
| Completed | ||
| </a> | ||
| </nav> | ||
| <TodoList /> |
There was a problem hiding this comment.
Will we render this component of todos length equal 0?
src/Store.tsx
Outdated
Comment on lines
8
to
14
| type State = { | ||
| todos: Todo[]; | ||
| query: string; | ||
| filter: SelectedFilter; | ||
| editingTodoId: number | null; | ||
| currentTitle: string; | ||
| }; |
There was a problem hiding this comment.
Consider creating .ts file and move this file to this file
src/Store.tsx
Outdated
Comment on lines
24
to
34
| type Action = | ||
| | { type: 'toogleAllChecked' } | ||
| | { type: 'addTodo'; payload: Todo } | ||
| | { type: 'setQuery'; payload: string } | ||
| | { type: 'deleteTodo'; payload: number } | ||
| | { type: 'massDelete'; payload: number[] } | ||
| | { type: 'changeCheckbox'; payload: number } | ||
| | { type: 'updateTodo'; payload: Todo } | ||
| | { type: 'setCurrentTitle'; payload: string } | ||
| | { type: 'setEditingTodoId'; payload: number | null } | ||
| | { type: 'setFilter'; payload: SelectedFilter }; |
src/components/TodoItem.tsx
Outdated
| import { Todo } from '../types/Todo'; | ||
| import { EditForm } from './EditForm'; | ||
| import { useGlobalDispatch, useGlobalState } from '../Store'; | ||
| // import { deleteFromLocalStorage } from '../utils/LocaleStorage'; |
src/components/TodoItem.tsx
Outdated
| const dispatch = useGlobalDispatch(); | ||
|
|
||
| const handleDeleteTodo = (index: number) => { | ||
| // deleteFromLocalStorage(id); |
src/utils/LocaleStorage.ts
Outdated
Comment on lines
3
to
15
| export const loadFromLocalStorage = (): Todo[] => { | ||
| const todos = localStorage.getItem('todos'); | ||
|
|
||
| return todos ? JSON.parse(todos) : []; | ||
| }; | ||
|
|
||
| export const deleteFromLocalStorage = (id: number) => { | ||
| let items = loadFromLocalStorage(); | ||
|
|
||
| items = items.filter((item: Todo) => item.id !== id); | ||
|
|
||
| localStorage.setItem('todos', JSON.stringify(items)); | ||
| }; |
There was a problem hiding this comment.
Consider creating useLocalStorageHook and replace this function with hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK