react_todo-app #1071
Open
react_todo-app #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I cant understand how to fix it
|
anastasiiavorobiova
suggested changes
Oct 30, 2024
| } finally { | ||
| setIsSubmiting(false); | ||
| } | ||
| } |
There was a problem hiding this comment.
Consider showing an error if the trimmed title is empty.
src/components/Header/Header.tsx
Outdated
| const handleSubmit = (event: React.FormEvent<HTMLFormElement>) => { | ||
| event.preventDefault(); | ||
|
|
||
| setIsSubmiting(true); |
There was a problem hiding this comment.
Suggested change
| setIsSubmiting(true); |
src/components/Header/Header.tsx
Outdated
| const newTitle = title.trim(); | ||
|
|
||
| if (newTitle) { | ||
| try { |
There was a problem hiding this comment.
Suggested change
| try { | |
| try { | |
| setIsSubmiting(true); |
etojeDenys
suggested changes
Oct 31, 2024
anastasiiavorobiova
suggested changes
Nov 5, 2024
|
I've already fixed it, but I don't make new deploy of the page, I thought it's not neccesary. So, I made deploy and now everything works correctly. Please check it. |
|
You have to change your UI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK