Develop #1089
Open
Develop #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
StasSokolov1
suggested changes
Dec 24, 2024
src/UserWarning.tsx
Outdated
Comment on lines
1
to
15
| // import React from 'react'; | ||
|
|
||
| // export const UserWarning: React.FC = () => ( | ||
| // <section className="section"> | ||
| // <p className="box is-size-3"> | ||
| // Please get your <b> userId </b>{' '} | ||
| // <a href="https://mate-academy.github.io/react_student-registration"> | ||
| // here | ||
| // </a>{' '} | ||
| // and save it in the app <pre>const USER_ID = ...</pre> | ||
| // All requests to the API must be sent with this | ||
| // <b> userId.</b> | ||
| // </p> | ||
| // </section> | ||
| // ); |
| type="button" | ||
| className="todoapp__clear-completed" | ||
| data-cy="ClearCompletedButton" | ||
| disabled={todos.length === completedTodosLength} |
There was a problem hiding this comment.
Suggested change
| disabled={todos.length === completedTodosLength} | |
| disabled={completedTodosLength === 0} |
it seems that it will be more informative
There was a problem hiding this comment.
Цей момент не спрацьовує, оскільки він не подібний, при переписуванні валяться тести на цю кнопку
src/components/Header.tsx
Outdated
| <header className="todoapp__header"> | ||
| {!!todos.length && ( | ||
| <button | ||
| onClick={() => changeCompleteAll()} |
There was a problem hiding this comment.
Suggested change
| onClick={() => changeCompleteAll()} | |
| onClick={changeCompleteAll} |
can be a bit simplify
src/hooks/useForm.tsx
Outdated
|
|
||
| const handleAddTodo = async (event: React.FormEvent<HTMLFormElement>) => { | ||
| event.preventDefault(); | ||
| if (query.trim()) { |
There was a problem hiding this comment.
query.trim() move into const and reuse
|
I changed the code a bit, rewrote it, added 'reduce' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
I don't know, I passed all 118 tests 😳