v1.0 #672
Open
v1.0 #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etojeDenys
suggested changes
Sep 6, 2023
etojeDenys
suggested changes
Sep 7, 2023
src/Components/TodoList.tsx
Outdated
Comment on lines
36
to
41
| if (todo.id === todoId) { | ||
| return { ...todo, title }; | ||
| // eslint-disable-next-line no-else-return | ||
| } else { | ||
| return todo; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (todo.id === todoId) { | |
| return { ...todo, title }; | |
| // eslint-disable-next-line no-else-return | |
| } else { | |
| return todo; | |
| } | |
| if (todo.id === todoId) { | |
| return { ...todo, title }; | |
| } | |
| return todo; | |
src/Components/TodoList.tsx
Outdated
Comment on lines
16
to
20
| useEffect(() => { | ||
| const savedTodos = JSON.parse(localStorage.getItem('todos') || '[]'); | ||
|
|
||
| setTodos(savedTodos); | ||
| }, []); |
There was a problem hiding this comment.
looks redundant cause you have your custom hook for localStorage
i can still reproduce the issue |
Anastasiia-Svintsova
suggested changes
Sep 11, 2023
public/src/App.tsx
Outdated
| const [isLoading, setIsLoading] = useState(false); | ||
| const [todos, setTodos] = useLocalStorage('todos', []); | ||
|
|
||
| const addNewTodo = async () => { |
There was a problem hiding this comment.
Do you really need an async function here? Seems that you await nothing here 🤔
public/src/App.tsx
Outdated
| </form> | ||
| </header> | ||
|
|
||
| {todos.length > 0 && ( |
There was a problem hiding this comment.
You can use logical operators as well
Suggested change
| {todos.length > 0 && ( | |
| {!!todos.length && ( |
public/src/Components/TodoList.tsx
Outdated
| const updatedTodos = todos.map((todo) => { | ||
| if (todo.id === todoId) { | ||
| return { ...todo, title }; | ||
| // eslint-disable-next-line no-else-return |
public/src/Components/TodoList.tsx
Outdated
| const updatedTodos = todos.map((todo) => { | ||
| if (todo.id === id) { | ||
| return { ...todo, completed: !completed }; | ||
| // eslint-disable-next-line no-else-return |
|
|
||
| import { TodoList } from './Components/TodoList'; | ||
| import { Footer } from './Components/Footer'; | ||
| import { Header } from './Components/Header'; |
There was a problem hiding this comment.
Rename the header.tsx to Header.tsx to fix linter errors
etojeDenys
suggested changes
Sep 11, 2023
|
|
||
| import { TodoList } from './Components/TodoList'; | ||
| import { Footer } from './Components/Footer'; | ||
| import { Header } from './Components/Header'; |
IvanFesenko
approved these changes
Sep 12, 2023
Comment on lines
+54
to
+64
| onChange={() => { | ||
| const updatedTodos = todos.map((todo) => { | ||
| if (todo.id === id) { | ||
| return { ...todo, completed: !completed }; | ||
| } | ||
|
|
||
| return todo; | ||
| }); | ||
|
|
||
| setTodos(updatedTodos); | ||
| }} |
There was a problem hiding this comment.
logic should be moved into separate handler instead on anonymous function in jsx.
Fix all similar cases
Comment on lines
+28
to
+51
| }; | ||
|
|
||
| return ( | ||
| <footer className="todoapp__footer"> | ||
| <span className="todo-count"> | ||
| {itemsLeftLength === 1 | ||
| ? '1 item left' | ||
| : `${itemsLeftLength} items left`} | ||
| </span> | ||
|
|
||
| <nav className="filter"> | ||
| {filterOptions.map((option) => { | ||
| return ( | ||
| <a | ||
| key={option} | ||
| href={`#/${option}`} | ||
| className={classNames( | ||
| 'filter__link', | ||
| { selected: filterBy === option }, | ||
| )} | ||
| onClick={() => setFilterBy(option)} | ||
| > | ||
| {option} | ||
| </a> |
There was a problem hiding this comment.
Suggested change
| }; | |
| return ( | |
| <footer className="todoapp__footer"> | |
| <span className="todo-count"> | |
| {itemsLeftLength === 1 | |
| ? '1 item left' | |
| : `${itemsLeftLength} items left`} | |
| </span> | |
| <nav className="filter"> | |
| {filterOptions.map((option) => { | |
| return ( | |
| <a | |
| key={option} | |
| href={`#/${option}`} | |
| className={classNames( | |
| 'filter__link', | |
| { selected: filterBy === option }, | |
| )} | |
| onClick={() => setFilterBy(option)} | |
| > | |
| {option} | |
| </a> | |
| }; | |
| const onFilterSelect = (filter: FilterType) => () => { | |
| setFilterBy(filter) | |
| } | |
| return ( | |
| <footer className="todoapp__footer"> | |
| <span className="todo-count"> | |
| {itemsLeftLength === 1 | |
| ? '1 item left' | |
| : `${itemsLeftLength} items left`} | |
| </span> | |
| <nav className="filter"> | |
| {filterOptions.map((option) => { | |
| return ( | |
| <a | |
| key={option} | |
| href={`#/${option}`} | |
| className={classNames( | |
| 'filter__link', | |
| { selected: filterBy === option }, | |
| )} | |
| onClick={onFilterSelect(option)} | |
| > | |
| {option} | |
| </a> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://JOWISSA.github.io/react_todo-app/