solution #7
solution #7
Conversation
src/App/App.js
Outdated
| this.setState({ ...state }); | ||
| } | ||
|
|
||
| componentWillUpdate(nextProps, nextState, nextContext) { |
There was a problem hiding this comment.
у этого метода нет никаких парметров!!!
src/App/App.js
Outdated
| } | ||
|
|
||
| changeFilter = async(e) => { | ||
| console.log(e.target); |
There was a problem hiding this comment.
поубирай пожалуйста лишний код
src/App/App.js
Outdated
| filterValue = filterValue[1]; | ||
| } else { | ||
| filterValue = ''; | ||
| } |
There was a problem hiding this comment.
если ты уже начал парсить href то пора использовать React Router
src/App/App.js
Outdated
| status = true; | ||
| break; | ||
| case 'active': | ||
| status = false; |
There was a problem hiding this comment.
чем создавать переменную проще тут сделать return того что нужно
Может добавится больше фильтров или логика изменится
Да и нагляднее будет - что именно возвращаем в каждом случае когда
src/App/App.js
Outdated
| const index = todosList.findIndex(todo => todo.id === id); | ||
| const togle = !todosList[index].completed; | ||
|
|
||
| todosList[index].completed = togle; |
There was a problem hiding this comment.
const todos = prevState.todos.map(todo => {
if (todo.id !== id) {
return todo;
}
return {
...todo,
completed: !todo.completed,
};
});
const completedTodos = todos.filter(todo => todo.completed)
return { todos, completedLength: completedTodos.length };
There was a problem hiding this comment.
src/App/App.js
Outdated
| }; | ||
| }); | ||
|
|
||
| completedLength = togle ? prevState.todosList.length : 0; |
There was a problem hiding this comment.
простота поддержки иногда важнее производительности
https://zoom.us/recording/share/0toADjnabJSYr5BrwhxuYQ8YXxuXzjke_u7ga_mD7cawIumekTziMw
src/App/App.js
Outdated
| const list = [...prevState.todosList]; | ||
| list.push(todoItem); | ||
| return { todosList: list, inputValue: '' }; | ||
| }); |
There was a problem hiding this comment.
There was a problem hiding this comment.
Всё досмотреть не успеваю
Внеси пожалуйста правки (и по другим моим видеоразборам изhttps://www.youtube.com/watch?v=EwHQ8MrrANE&list=PL7FuXFaDeEX3AbsSUG1LvTr8UF5UvKatw)
| { | ||
| todosLength > 0 && ( | ||
| <> | ||
| <TodoList filter={params.filter} /> |
There was a problem hiding this comment.
ToDoList in heder? footer in heder???
DEMO