Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip nblas tests if nblas unavailable #250

Closed
wants to merge 630 commits into from

Conversation

rotu
Copy link
Contributor

@rotu rotu commented Aug 31, 2023

No description provided.

mateogianolio and others added 30 commits December 21, 2016 20:48
This badge will show the version on CDNJS!
add CDNJS version badge in README.md
add binary operation function to vector
optimize for loop by pre-calculating size
make callback function takes original data array
mateogianolio and others added 25 commits April 17, 2023 22:03
Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v2.2.1...v2.2.3)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mateo Gianolio <[email protected]>
* Add prettier formatter

* [skip ci] Bump version
* Remove non-null assertions

* 6.1.8
* Remove non-null assertions

* 6.1.8

* Split up iterators into separate files

* 6.1.9
* Remove old benchmarks and add benchmarks to .gitignore

* Add benchmarks to iterators

* Improvement/renaming to bench script

* 6.1.10
…#239)

* Remove next2d and next1d from NDIter and add test case

* 6.1.11
* Improve test for multidimensional iterator

* Improve tests for matrix multiply

* Add blas.ts tests (except gemm)

* Test unoptimized path for add()

* Test unoptimized path for dot()

* Test unoptimized path for inv()

* Test unoptimized path for multiply()
use rimraf instead of `rm -rf`. This makes the build work on Windows.

Co-authored-by: Mateo Gianolio <[email protected]>
@rotu rotu changed the title skip nblas tests if nblas unavaliable skip nblas tests if nblas unavailable Sep 1, 2023
@rotu rotu marked this pull request as draft September 1, 2023 19:33
@rotu
Copy link
Contributor Author

rotu commented Sep 2, 2023

I'm not currently happy with the state of this PR and am not sure the way forward.

The require('nblas') statements causes typescript to bail (nblas is inferred to have type any). A similar import('nblas') is responsible for #255.

Another option is to switch to import('nblas') which WOULD infer types, but Jest does not provide for asynchronously skipping tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants