This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
Add support for multiple transitions per view controller transition #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31.
This is a breaking change due to removal of APIs and changing of nullability annotations on existing APIs.
This PR allows a client to associate multiple
Transition
instances with a single view controller transition. When a transition is initiated, eachTransition
instance will be provided the same transition context.This allows us to build smaller transition types, such as "FadeTransition" or "SlideTransition" which each accept a target view. These transitions can then be combined to create a "slide and fade in transition" like so:
Some open questions this change has introduced:
context.resolvedView(for: view)
, which would be routed through a shared view duplicator.TransitionWithChildTransitions
protocol that allows the parent transition to return an array of child transitions.