Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2_control_node-7] [ERROR] [controller_manager]: Can't activate controller 'omnidirectional_controller': State interface with key 'joint_name/velocity' does not exist #8

Closed
robotcopper opened this issue Mar 31, 2024 · 3 comments

Comments

@robotcopper
Copy link
Contributor

Hello @mateusmenezes95 ,

I am trying to use your controller in addition of the topic_based_ros2_control hardware interface.

The thing is that on my real robot i do not need of state interface. Indeed I am controlling my robot in open loop. So as you can expect, i set the open_loop param to True and as i saw it in the omnidirectional_controller.cpp it indeed unset the use of the state estimation tool.

However, in the omnidirectional_controller.cpp the controller keep looking for a state_interface even if the open_loop is True.

Or we could expect that only command would be send in open_loop, so in other words, just needing command_interface in the hardware_interface and not also a state_interface am i right?

So is it a bug? Did I miss something?

Here is what i expect to implement as hardware_interface:
image

PS: Thank you again for this very useful work you have made

@mateusmenezes95
Copy link
Owner

Hello @robotcopper!

Thank you so much for your great description of the issue. And you are right: It's a bug.

Do you want propose a PR fixing it?

@robotcopper
Copy link
Contributor Author

Hello @robotcopper!

Thank you so much for your great description of the issue. And you are right: It's a bug.

Do you want propose a PR fixing it?

Hello @mateusmenezes95 , no problem. I made one. I tested it in open and closed loops and no regression appeared.

@mateusmenezes95
Copy link
Owner

Fixed in #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants