Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call to state interface even in open_loop #9

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Fix call to state interface even in open_loop #9

merged 4 commits into from
Apr 11, 2024

Conversation

robotcopper
Copy link
Contributor

Fix the problem raised by this issue

Copy link
Owner

@mateusmenezes95 mateusmenezes95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the contribution. I have only two comments

src/omnidirectional_controller.cpp Outdated Show resolved Hide resolved
src/omnidirectional_controller.cpp Outdated Show resolved Hide resolved
Copy link
Contributor Author

@robotcopper robotcopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think the merger is possible now?

@mateusmenezes95 mateusmenezes95 self-requested a review April 11, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants