Skip to content

Commit

Permalink
Resolve TODO_BETA task for array item_type type_option
Browse files Browse the repository at this point in the history
  • Loading branch information
pavish committed Dec 18, 2024
1 parent fbfdba8 commit 338c4d2
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions mathesar_ui/src/systems/data-explorer/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -482,15 +482,9 @@ export function speculateColumnMetaData({
type_options:
aggregation.function === 'distinct_aggregate_to_array'
? {
// TODO_BETA: Ask Pavish.
//
// `Column['type_options']` was previously typed loosely
// as `Record<string, unknown> | null`. Now it's more
// strict and it doesn't have a `type` property.
//
// type:
// updatedColumnsMetaData.get(aggregation.inputAlias)
// ?.column.type ?? 'unknown',
item_type:
updatedColumnsMetaData.get(aggregation.inputAlias)
?.column.type ?? 'unknown',
}
: null,
metadata: null,
Expand Down

0 comments on commit 338c4d2

Please sign in to comment.