Skip to content

Commit

Permalink
Merge pull request #3976 from mathesar-foundation/positional_paramete…
Browse files Browse the repository at this point in the history
…r_indexes

SQL comments to index positional arguments
  • Loading branch information
seancolsen authored Oct 23, 2024
2 parents 3d20c0f + ed2c48a commit 61523cb
Showing 1 changed file with 21 additions and 15 deletions.
36 changes: 21 additions & 15 deletions db/sql/00_msar.sql
Original file line number Diff line number Diff line change
Expand Up @@ -4852,21 +4852,27 @@ BEGIN
LEFT JOIN groups_cte ON enriched_results_cte.__mathesar_gid = groups_cte.id %13$s
CROSS JOIN count_cte
$q$,
msar.build_selectable_column_expr(tab_id),
msar.get_relation_schema_name(tab_id),
msar.get_relation_name(tab_id),
limit_,
offset_,
msar.build_order_by_expr(tab_id, order_),
msar.build_where_clause(tab_id, filter_),
msar.build_grouping_expr(tab_id, group_),
msar.build_results_jsonb_expr(tab_id, 'enriched_results_cte', order_),
COALESCE(msar.build_grouping_results_jsonb_expr(tab_id, 'groups_cte', group_), 'NULL'),
COALESCE(msar.build_groups_cte_expr(tab_id, 'results_ranked_cte', group_), 'NULL AS id'),
msar.build_summary_cte_expr_for_table(tab_id),
msar.build_summary_join_expr_for_table(tab_id, 'enriched_results_cte'),
COALESCE(msar.build_summary_json_expr_for_table(tab_id), 'NULL'),
COALESCE(
/* %1 */ msar.build_selectable_column_expr(tab_id),
/* %2 */ msar.get_relation_schema_name(tab_id),
/* %3 */ msar.get_relation_name(tab_id),
/* %4 */ limit_,
/* %5 */ offset_,
/* %6 */ msar.build_order_by_expr(tab_id, order_),
/* %7 */ msar.build_where_clause(tab_id, filter_),
/* %8 */ msar.build_grouping_expr(tab_id, group_),
/* %9 */ msar.build_results_jsonb_expr(tab_id, 'enriched_results_cte', order_),
/* %10 */ COALESCE(
msar.build_grouping_results_jsonb_expr(tab_id, 'groups_cte', group_),
'NULL'
),
/* %11 */ COALESCE(
msar.build_groups_cte_expr(tab_id, 'results_ranked_cte', group_),
'NULL AS id'
),
/* %12 */ msar.build_summary_cte_expr_for_table(tab_id),
/* %13 */ msar.build_summary_join_expr_for_table(tab_id, 'enriched_results_cte'),
/* %14 */ COALESCE(msar.build_summary_json_expr_for_table(tab_id), 'NULL'),
/* %15 */ COALESCE(
CASE WHEN return_record_summaries THEN msar.build_self_summary_json_expr(tab_id) END,
'NULL'
)
Expand Down

0 comments on commit 61523cb

Please sign in to comment.