Merge pull request #3334 from mathesar-foundation/eslint-plugin-svelte

Replace eslint-plugin-svelte3 with officially supported eslint-plugin-svelte plugin
mathesar-foundation · Dec 6, 2023 · bea549a · bea549a
2 parents 7c39f5f + dd18b5e
commit bea549a
Show file tree

Hide file tree

Showing 30 changed files with 347 additions and 199 deletions.
diff --git a/mathesar_ui/.eslintrc.cjs b/mathesar_ui/.eslintrc.cjs
@@ -1,22 +1,27 @@
-const typescript = require('typescript');
-
 module.exports = {
   root: true,
   parser: '@typescript-eslint/parser',
-  ignorePatterns: ['node_modules', 'dist', 'index.html'],
+  ignorePatterns: [
+    'node_modules',
+    'dist',
+    'index.html',
+    'src/**/*.stories.svelte',
+  ],
   parserOptions: {
     tsconfigRootDir: __dirname,
     project: ['./tsconfig.json'],
-    extraFileExtensions: ['.svelte', '.cjs', '.json'],
+    extraFileExtensions: ['.svelte', '.json'],
   },
-  plugins: ['svelte3', '@typescript-eslint'],
+  plugins: ['@typescript-eslint'],
   extends: [
     'airbnb-base',
     'airbnb-typescript/base',
     'plugin:eslint-comments/recommended',
     'plugin:promise/recommended',
     'plugin:@typescript-eslint/recommended',
     'plugin:@typescript-eslint/recommended-requiring-type-checking',
+    'plugin:svelte/recommended',
+    'plugin:svelte/prettier',
   ],
   rules: {
     'import/no-extraneous-dependencies': ['error', { devDependencies: true }],
@@ -43,7 +48,10 @@ module.exports = {
   overrides: [
     {
       files: ['*.svelte'],
-      processor: 'svelte3/svelte3',
+      parser: 'svelte-eslint-parser',
+      parserOptions: {
+        parser: '@typescript-eslint/parser',
+      },
       rules: {
         'import/first': 'off',
         'import/no-duplicates': 'off',
@@ -76,6 +84,10 @@ module.exports = {
         '@typescript-eslint/no-unsafe-argument': 'off',
         'no-sequences': 'off',
         '@typescript-eslint/no-unused-expressions': 'off',
+        '@typescript-eslint/no-unused-vars': [
+          'warn',
+          { varsIgnorePattern: '^\\$\\$(Props|Events|Slots)$' },
+        ],
       },
     },
     {
@@ -146,10 +158,9 @@ module.exports = {
   },
   globals: {
     vi: true,
+    $$Generic: 'readonly',
   },
   settings: {
-    'svelte3/typescript': () => typescript,
-    'svelte3/ignore-styles': ({ lang }) => lang === 'scss',
     'import/resolver': {
       node: {
         extensions: ['.js', '.ts'],