Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI pipeline not working properly #3261

Closed
mathemancer opened this issue Oct 26, 2023 · 0 comments · Fixed by #3254
Closed

CI pipeline not working properly #3261

mathemancer opened this issue Oct 26, 2023 · 0 comments · Fixed by #3254
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@mathemancer
Copy link
Contributor

Description

Currently, the CI pipeline is:

  • skipping tests but treating them as having succeeded when an internal mathesar contributor makes a PR under certain conditions
  • Not allowing merging in some conditions since tests skipped due to branch/path restrictions are marked pending rather than success
  • Broken whenever backend tests need to run since the setup defined in run-pytest.yml is defective

Expected behavior

The CI pipeline should always:

  • Run tests relevant to any changed code before merging
  • Avoid hanging due to non-runs of irrelevant tests
  • Use a correct setup for python testing.

Additional context

Blocking #3243 , #3245 , and potentially others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant