-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add jobs for testing strategy branches #3254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also add .py change for testing
mathemancer
added
priority: urgent
Blocks other ongoing work
pr-status: review
A PR awaiting review
labels
Oct 26, 2023
I've marked this as 'urgent', since the fix is blocking merging backend PRs, and the current state of branch protections necessary for properly reviewing this PR blocks merging all other PRs. |
7 tasks
kgodey
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, review conducted on a call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3261
This PR modifies the CI pipeline testing logic in the following way:
All testing, linting, auditing, etc. jobs are now in the same workflow, called "Test and Lint Code" .
Each job is dependent on a job that checks whether relevant files have changed. For example, the front end testing job is dependent on a job that checks whether any file under
mathesar_ui
has changed. If such a file has changed, the job runs the tests, otherwise the job ends in askipped
state. This state is sufficient to allow PRs to merge. Thus, we no longer need dummy jobs to run so that PRs which don't change, e.g.,mathesar_ui/**
can be merged.Also, all such jobs are moved into the same workflow and same workflow file. The reason for this is that:
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin