Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with creating records on tables without a primary key #3252

Merged
merged 6 commits into from
Oct 31, 2023

Conversation

Shraeyas
Copy link
Contributor

Fixes #3246

Technical details

  • Added condition to check if a primary key exists on table and updated error message to "You cannot insert into tables without a primary key" and status code to 405 if a user tries to insert a new record.
  • Added MethodNotAllowedAPIException error class.
  • Updated test coverage for validating record creation on tables without primary key .

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Shraeyas
Copy link
Contributor Author

@mathemancer This will fix #3246

I've updated the tests as well. Can you review this?

@Shraeyas
Copy link
Contributor Author

Not sure why the particular test is failing. It is working fine on my local setup.

@mathemancer
Copy link
Contributor

@Shraeyas Don't worry about that test failure. We have a problem with the CI pipeline, addressed by #3254

Copy link
Contributor

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, pretty good!

I do have one small request; see the specific comment.

primary_key_column_name = None
try:
primary_key_column_name = table.primary_key_column_name
except Exception:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check for a more specific Exception here.

Copy link
Contributor Author

@Shraeyas Shraeyas Oct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed it to 'AssertionError'. Refer to this commit.

@mathemancer @Anish9901

@Shraeyas Shraeyas requested a review from mathemancer October 27, 2023 08:46
Copy link
Member

@Anish9901 Anish9901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Shraeyas, thanks for your contribution!

@Anish9901 Anish9901 enabled auto-merge October 31, 2023 14:23
@Anish9901 Anish9901 dismissed mathemancer’s stale review October 31, 2023 14:47

Ready to be merged

@Anish9901 Anish9901 added this pull request to the merge queue Oct 31, 2023
Merged via the queue into mathesar-foundation:develop with commit dcedbe6 Oct 31, 2023
21 checks passed
@Anish9901 Anish9901 removed their assignment Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Insert broken when there's not primary key
4 participants