-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cell tab in table inspector for showing cell content #2778
add cell tab in table inspector for showing cell content #2778
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, fix the lint and format check failures.
Also, you've based this on an abandoned PR and implemented the changes requested in that PR: #2385
This is the second PR you're basing off of someone else's work, without saying that. As I said on the other PR, that looks pretty bad.
I'd like to apologize once again. I raised my PR after thoroughly reviewing #2385 and discovering that there had been no response to the suggested review. My intention was to help resolve the issue as quickly as possible. However, I realize that I made a mistake by not referencing the PRs and failing to comment on this matter when I submitted my own PR. I'm truly sorry for any confusion or inconvenience caused by my oversight. |
…raunak-dev-edu/mathesar into cell_contentin_table_inspector_Cell_tab
@dmos62 I am going to start the review on this since the lint checks are now passing. |
This pull request has not been updated in 45 days and is being marked as stale. It will automatically be closed in 30 days if not updated by then. |
This pull request has not been updated in 45 days and is being marked as stale. It will automatically be closed in 30 days if not updated by then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @raunak-dev-edu. I added a few commits to clean up some small things.
c73ac65
Fixes #2342
This Pull request will add a cell tab in the table inspector in the table page that will show cell content similar to the inspector in Exploration Page.
Screenshots
Like this -
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin