-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Django REST Framework settings to use JSONParser as the default parser for incoming requests #3090
Updated Django REST Framework settings to use JSONParser as the default parser for incoming requests #3090
Conversation
…lt parser for incoming requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test cases are failing. This is happening because uploading /datafiles/
API relies on the multipart/form-data
. So you would need to add additional multipart/form-data
parser support for the /datafiles/
API. Please request a review once the test cases are passing
Sure, I'll check |
…ndpoints, by adding a parser class to the DEFAULT PARSER CLASSES
…andling both file uploads and JSON data
@varshadr I'm re-assigning this to @mathemancer because Mukesh will no longer be working with you on this project. Please assign any further PRs to @mathemancer for review. |
Sure @seancolsen , I will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Nice work, @varshadr !
It's obsolete, the changes have been made.
Fixes #3089
This PR removes unnecessary application/x-www-form-urlencoded and multipart/form-data content types from the requestBody section in relevant API endpoints, by updating the Django REST Framework settings to use JSONParser as the default parser for incoming requests.
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin