-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18n] Export & import translations #3123
Conversation
@rajatvijay I've skimmed the diff but I'm not really sure how to review this. Can you provide some more instruction for me? What do I do to test this out? What should I expect to happen if it works? This is the sort of PR that I think would be ideal to make in tandem with developer documentation that explains how it all works. Can we get started on that documentation now? It doesn't need to be perfect, but it's the sort of thing that will help me and Mukesh review this PR. And in running through the documentation while reviewing the PR, we'd also be stress-testing the documentation at the same time (which I think works better than trying to do it later, on its own, once someone like me already understands the whole process). |
Agreed. I am not sure what is meant by "Uploading BE translations to transifex", I assume it is for uploading the string to be translated. It will be good to understand the translation process before the PR is reviewed |
…thesar into i18n-export-import-translations
@seancolsen @silentninja Added the translations required for review. |
@pavish said he would take this off my plate today, so I'm re-assigning it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rajatvijay This PR is stacked on top of #3104, which is again stacked on another PR #3103 which has a number of conflicts. Please address them so that the reviewers can test this PR.
Also, I think it would be better to have the following before reviewing the PR:
- Most of the code in this PR is NodeJS and not frontend code. I'd like them to be present in an entirely separate directory instead of the the frontend source code (i.e. outside of
/src
). - Add the dependencies (
gettext
) to the docker image (or atleast add commands to the dev docker compose setup), instead of having to do it manually. Provide the dev documentation for the entire process, as both @seancolsen and @silentninja have pointed out.Just noticed that it's provided.
I'm marking this PR as a draft until all these are addressed.
Assigning to @pavish to finish the remaining work here |
… i18n-export-import-translations
Closing this PR as this is superseded by #3321 |
Relates #2927
Pre-requisites
It needs GNU's
gettext
to be installed in the dockerI will add this to the documentation once I get to the documentation tasks listed here.
Uploading BE translations to transifex
Downloading BE translations from transifex
Uploading FE translations to transifex
Downloading FE translations from transifex
Env token
These scripts need
TRANSIFEX_TOKEN
to be able to authenticate with the transifex service and identifymathesar
project.The scripts are written in a way that if the
TRANSIFEX_TOKEN
is not available in the environment it prompts the user.Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin