Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Db connection UI #3223

Merged
merged 40 commits into from
Oct 25, 2023
Merged

Db connection UI #3223

merged 40 commits into from
Oct 25, 2023

Conversation

rajatvijay
Copy link
Contributor

@rajatvijay rajatvijay commented Sep 22, 2023 •
edited by seancolsen
Loading

Fixes #3161

Technical details

https://www.loom.com/share/a3e351f7e34447cfb8658b71d42e51dc

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@kgodey
Copy link
Contributor

kgodey commented Sep 27, 2023

Quick note to @seancolsen and @rajatvijay that I'd like to review this UI / flow before the release goes out (doesn't have to block merge of this PR).

@seancolsen seancolsen added this to the v0.1.4 milestone Oct 2, 2023
@seancolsen seancolsen mentioned this pull request Oct 2, 2023
Merged
7 tasks
@rajatvijay rajatvijay marked this pull request as ready for review October 2, 2023 19:14
rajatvijay
rajatvijay commented Oct 2, 2023
View reviewed changes
mathesar/views.py
Comment on lines +83 to +88
'id': db.id,
'username': db.username,
'port': db.port,
'host': db.host,
'name': db.name,
'db_name': db.db_name,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anish9901 added attributes here required when editing

@rajatvijay rajatvijay requested a review from pavish October 2, 2023 19:17
@rajatvijay rajatvijay assigned kgodey, pavish and Anish9901 and unassigned rajatvijay Oct 2, 2023
@rajatvijay rajatvijay assigned pavish and unassigned rajatvijay Oct 5, 2023
@rajatvijay rajatvijay added pr-status: review A PR awaiting review and removed pr-status: revision A PR awaiting follow-up work from its author after review labels Oct 5, 2023
@rajatvijay rajatvijay requested a review from pavish October 5, 2023 20:10
@dmos62 dmos62 force-pushed the db-connection-pages branch from 98e60ea to 3edd094 Compare October 9, 2023 16:13
pavish
pavish approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajatvijay Thanks for addressing all my concerns. This looks good, I had a couple small comments which do not have to be fixed in this PR.

Feel free to merge this once this comment and the comments from other reviewers are resolved.

There is a discussion around the non-editable DB UX, which isn't resolved yet. @silentninja is handling further discussion and getting it to a conclusion. I do not think this PR needs to be held. We can make changes once the discussion yields a decision. Please check with @silentninja on the status of the discussion.

mathesar_ui/src/pages/database/DatabaseDetails.svelte

async function handleSuccessfulDeleteConnection() {
await reloadDatabases();
router.goto('/');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When disconnecting a DB from the administration route, the url redirect should not go to the root route, it should go to the administration/db-connection route.

mathesar_ui/src/pages/database-connection/AddDatabaseConnection.svelte Outdated
import { router } from 'tinro';
import { reloadDatabases } from '@mathesar/stores/databases';
import { reflectApi } from '@mathesar/api/reflect';
import FormBox from '../admin-users/FormBox.svelte';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this FormBox to a more common location. It currently seems to be specific to a different route, and referencing components from across routes reduces modularity.

@pavish pavish assigned silentninja and rajatvijay and unassigned pavish Oct 9, 2023
@rajatvijay
fixes related to review comments
cb08572 
1. moved FormBox for common/form
2. after disconnecting db from the edit db connection page
the user is now redirected to the db connections list page
3. help text update in the db connection form
@rajatvijay
Copy link
Contributor Author

@silentninja this PR is now approved. Marking it as blocked on the missing documentation links. I will update the PR once you provide them & merge it.

@rajatvijay rajatvijay added needs: unblocking Blocked by other work and removed pr-status: review A PR awaiting review labels Oct 10, 2023
@ghislaineguerin ghislaineguerin mentioned this pull request Oct 13, 2023
Closed
@dmos62 dmos62 mentioned this pull request Oct 24, 2023
Closed
@seancolsen seancolsen enabled auto-merge October 25, 2023 18:44
@seancolsen seancolsen added this pull request to the merge queue Oct 25, 2023
@seancolsen
Copy link
Contributor

I fixed some merge conflicts in this PR and queued it to merge. This whole UI is about to change anyway, given our new design, so I don't think it's worth holding this PR up anymore for the docs links.

Merged via the queue into develop with commit cd3b437 Oct 25, 2023
22 of 25 checks passed
@seancolsen seancolsen deleted the db-connection-pages branch October 25, 2023 18:50
@seancolsen seancolsen mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silentninja silentninja silentninja left review comments

@pavish pavish pavish approved these changes

Assignees

@silentninja silentninja

@rajatvijay rajatvijay

Labels
needs: unblocking Blocked by other work
Projects
No open projects
[NO LONGER USED] Mathesar work tracker
Status: Done
Milestone
v0.1.4
Development

Successfully merging this pull request may close these issues.

UI for adding/modifying user database credentials in Mathesar
7 participants
@rajatvijay @kgodey @dmos62 @seancolsen @silentninja @pavish @Anish9901