-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate OpenAPI specification for links endpoint #3251
Generate OpenAPI specification for links endpoint #3251
Conversation
@@ -266,6 +374,33 @@ paths: | |||
schema: | |||
$ref: '#/components/schemas/Database' | |||
description: '' | |||
/api/db/v0/links/: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@silentninja could you please review the spec for links
, here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@silentninja I'm suggesting we close this PR. The /links/
endpoint has already been merged into the develop branch and its API documentation is generated through another PR that is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! @varshadr Can you resolve the conflicts and merge the pull request
@varshadr, in looking over PRs, I've noticed a few assigned to Mukesh. We shouldn't have any PRs assigned to him anymore. In general, please assign to @mathemancer going forward. But for this PR in particular, I'm not sure why you've assigned it to anyone else, given the recent approving review post here. As far as I can tell, the next steps for this PR are for you to resolve the merge conflicts and then merge the PR yourself. If you need help with any remaining steps, please ask specific questions to specific people so that the comments here clearly indicate the remaining work needed. If you need help resolving merge conflicts, it might be good to ask in Matrix. One of us can even hop on a call with you to help out if needed. |
@seancolsen The |
We're reprioritizing, and unfortunately we won't be continuing the documentation project. |
Fixes #3153
This PR add openAPI specification for
links
endpoint to the schema fileChecklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin