Structures Dockerfile based on operation, and simplifies dev environment

[pavish]

Fixes #2973

Technical details

• Dockerfile:
  • Adds structure to our Dockerfile, based on operation performed. Previously:
    • It wasn't clear where to add a new dependency that I wanted installed
  • Removes dockerize.It isn't needed after the changes to the compose file (see next parah)
  • Installs gettext, which is required for i18n project
• docker-compose.dev.yml
  • Removes dependency between dev-service and service, which fixes Starting the dev service starts the db container which is nonessential #2973
  • Checks healthcheck of db, instead of using dockerize to regularly check if tcp port is open

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the develop branch of the repository
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no
  visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[pavish]

@mathemancer I'm just noticing that changes to the Dockerfile, and compose script, do not run our tests. I think we should change this behaviour to run tests.

[mathemancer]

Looks good overall, but see my specific comment on the Dockerfile.

[mathemancer]

It's important to use apt-get update in the same RUN command as apt-get install whenever the latter is used.

See: https://docs.docker.com/develop/develop-images/instructions/#apt-get

[pavish]

Thanks! I've added f8011db to resolve this.

[mathemancer]

Okay, this looks good to me.