-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace typesafe-i18n with svelte-i18n #3302
Replace typesafe-i18n with svelte-i18n #3302
Conversation
…ncies to dependencies
… poc_replace_typesafe_i18n_with_svelte_i18n
c435a35
to
7ee3b43
Compare
… poc_replace_typesafe_i18n_with_svelte_i18n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work on this, @pavish. I'm very happy with the direction this is heading!
Out of curiosity, I noticed that you moved tinro from dev-dependencies
to dependencies
. Why? I guess I would actually expect it to be in dependencies
from the start. Were you observing a problem with it being in dev-dependencies
? If so, what were the symptoms you were observing?
For frontend projects with a build step, it usually does not matter if we have the dependencies in either one of these places. There was no problem with tinro being in The only place where it would matter is when we run |
Technical details
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin