Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for scientific notation in number input components #1247 #3315

Closed
wants to merge 4 commits into from

Conversation

gulianow
Copy link

@gulianow gulianow commented Nov 20, 2023

Added support for scientific notation in number input components and also added tests

Fixes #1247

Technical details

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@seancolsen
Copy link
Contributor

Thanks for this PR, @gulianow! I can tell you put a good amount of time and thought into this. I look forward to reviewing it. However, I'll be on vacation shortly, so it will probably be a few weeks before I'm able to begin the review.

@seancolsen seancolsen self-assigned this Nov 20, 2023
@seancolsen seancolsen added the pr-status: review A PR awaiting review label Nov 20, 2023
@seancolsen seancolsen added this to the Backlog milestone Nov 20, 2023
@gulianow
Copy link
Author

gulianow commented Dec 9, 2023

Hi, I don't want to bother you, but how does it look with your review?

@seancolsen
Copy link
Contributor

@gulianow Reviewing this PR is still on my to-do list, but is queued below a number of higher-priority tasks. I'll get to it at some point, but I can't promise it will be before the end of the month because this change is a rather low priority for the product.

In the mean time, I'll say this: from a quick glance at the diff, I noticed that your latest commit changes some python files. The changes in this PR should be limited to files contained within mathesar_ui/src/component-library/number-input, as was the case with your first commit.

@gulianow
Copy link
Author

Yes, I understand. I am sorry, I changed and pushed some python files by mistake. Now they should be deleted from pull request.
Thanks a lot.

@seancolsen
Copy link
Contributor

Closing per comment on ticket

@seancolsen seancolsen closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Add support for scientific notation in number input components
2 participants