Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Db Connections page and Welcome page #3326

Merged
merged 28 commits into from
Dec 4, 2023
Merged

Conversation

pavish
Copy link
Member

@pavish pavish commented Nov 29, 2023

Fixes #3297

Connections UI:

  • Implements the welcome page.
  • Implements the connections listing route.
  • The home route redirection logic is now as the follows:
    • When there is a single connection, we direct it to the database route.
    • When there are multiple connections, we direct it to the connections listing route.
    • When there are no connections, we display the welcome page.
  • Implements UI for editing and deleting connections.
  • Adds a placeholder UI for adding connections.
  • Adds links to the connections listing page in breadcrumb, and top right menu.

Refactors:

  • Rewrites the database store to reflect the new connections model.
  • Does a number of refactors for the change from Database to Connection throughout the app, picking low-hanging fruits.

What the PR doesn't do:

  • It does not change the db page url from /db/<connection_name>/ to /db/<connection_id>/.
    • This is because the PR is already large, and the above change would only add clutter, and it can be handled separately.
    • I'd like the new url to be /connections/<connection_id>/ instead.
  • I opened Frontend followup work on Database connections UI #3328 to track this and more items I noticed while implementing the Connections UI.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@pavish pavish force-pushed the db_connections_page branch from 533ef5c to 23e3181 Compare November 30, 2023 17:48
@pavish pavish marked this pull request as ready for review November 30, 2023 21:27
@pavish pavish added the pr-status: review A PR awaiting review label Nov 30, 2023
@pavish pavish requested a review from seancolsen November 30, 2023 21:28
@pavish pavish added this to the v0.1.4 milestone Nov 30, 2023
Copy link
Contributor

@seancolsen seancolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @pavish. Thank you!

One thing that still needs to be done is making the connection nickname editable, but that can be done after we merge this. I've opened #3333 to track that.

@seancolsen seancolsen added this pull request to the merge queue Dec 4, 2023
Merged via the queue into develop with commit e86f93a Dec 4, 2023
20 checks passed
@seancolsen seancolsen deleted the db_connections_page branch December 4, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Front end work to re-organize DB connections
2 participants