Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate /src/components, add linting and formatting rules #3337

Merged
merged 10 commits into from
Dec 6, 2023

Conversation

pavish
Copy link
Member

@pavish pavish commented Dec 6, 2023

This PR

  • Adds linting rule for raw text in components
  • Translates /src/components
  • Updates prettier and prettier-plugin-svelte
  • Addsprettier-plugin-sort-json to sort keys in json files
  • Sets up i18n stores in test environment

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@pavish pavish added the pr-status: review A PR awaiting review label Dec 6, 2023
@pavish pavish added this to the v0.1.5 milestone Dec 6, 2023
@pavish pavish requested a review from seancolsen December 6, 2023 11:01
@pavish
Copy link
Member Author

pavish commented Dec 6, 2023

This PR is ready for review, however I'm marking it as a draft since it stacks on top of #3334, which isn't merged yet.

@pavish pavish marked this pull request as draft December 6, 2023 11:03
@pavish pavish changed the title Translate /src/components, update prettier, add prettier plugin to sort keys in json files Translate /src/components, update prettier, add json sorting prettier plugin, setup i18n for tests Dec 6, 2023
@pavish pavish changed the title Translate /src/components, update prettier, add json sorting prettier plugin, setup i18n for tests Translate /src/components, add linting and prettier rules Dec 6, 2023
@pavish pavish changed the title Translate /src/components, add linting and prettier rules Translate /src/components, add linting and formatting rules Dec 6, 2023
Base automatically changed from eslint-plugin-svelte to develop December 6, 2023 17:02
@seancolsen seancolsen marked this pull request as ready for review December 6, 2023 17:02
Copy link
Contributor

@seancolsen seancolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pavish and I chatted about this on a call. I had some questions and concerns, but none of them are urgent and he plans to address all of them later.

@seancolsen seancolsen added this pull request to the merge queue Dec 6, 2023
Merged via the queue into develop with commit 1c71c26 Dec 6, 2023
18 checks passed
@seancolsen seancolsen deleted the translate-app branch December 6, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants