Improve Edit Connection form

[seancolsen]

Fixes #3384

Comparison

Before	After

Changes

• Disable "Database Name", "Host", and "Port" fields, per Modifying database name, host name, or port number could result in a connection to a DB without Mathesar schemas #3384.

• Add help text explaining why those fields are disabled. Link to Unable to edit DB name, host, and port for existing connections #3386 within help text.

• Remove "Why is this needed?" hyperlink which does not point anywhere. We can add this back once we have documentation to reference.

• Add a checkbox field to improve password-changing UI. When the box is checked, a password field appears like this:

  

  At that point the password field is required.

  I think this is a lot cleaner. There is less help text for the user to read, and the "Change Password" label is now associated with an actual input instead of with nothing.

• Reset the form when the modal opens. Before this change there was a bug. If I made some changes to the form and then closed the modal with the X button, re-opening the modal would show the changes I had already made. After this change, re-opening the modal in such a case shows the reset values.

• Change the "Cancel" button to a "Reset" button.

• Disable saving if there are no form modifications.

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the develop branch of the repository
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[seancolsen]

@kgodey and @ghislaineguerin you might like to look over the screenshots in the PR description to see if you have any concerns with these changes since I've improvised a few minor things here.

[kgodey]

@seancolsen looks good to me, only change I'd suggest is "mean time" --> "meantime".

[seancolsen]

@kgodey

"mean time" --> "meantime"

Thanks! Learned something today! 🙂 Fixed in 97ae1c0.

[pavish]

Looks good to me!