Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constraints rpc transition (list, delete & add) #3664

Merged
merged 14 commits into from
Jul 9, 2024
Merged

Conversation

Anish9901
Copy link
Member

@Anish9901 Anish9901 commented Jul 3, 2024

Fixes #3594

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Anish9901 Anish9901 changed the title Constraints rpc Constraints rpc transition Jul 5, 2024
@Anish9901 Anish9901 requested a review from mathemancer July 5, 2024 13:26
@Anish9901 Anish9901 added the pr-status: review A PR awaiting review label Jul 5, 2024
@Anish9901 Anish9901 marked this pull request as ready for review July 5, 2024 13:26
@Anish9901 Anish9901 changed the title Constraints rpc transition Constraints rpc transition (list, patch and add) Jul 5, 2024
@Anish9901 Anish9901 changed the title Constraints rpc transition (list, patch and add) Constraints rpc transition (list, delete & add) Jul 5, 2024
Copy link
Contributor

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work to both @seancolsen and @Anish9901 on this one!

@mathemancer mathemancer added this pull request to the merge queue Jul 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 9, 2024
@mathemancer mathemancer enabled auto-merge July 9, 2024 06:54
@mathemancer mathemancer added this pull request to the merge queue Jul 9, 2024
Merged via the queue into develop with commit 3cb5280 Jul 9, 2024
39 checks passed
@mathemancer mathemancer deleted the constraints_rpc branch July 9, 2024 07:20
@seancolsen
Copy link
Contributor

We exchanged a few messages in Matrix regarding the new pattern I introduced in this PR of RETURN TABLE. I just noticed an additional point in favor of this new pattern that I'd like to highlight here...

When OID values are serialized to JSON via psycopg (as with RETURN TABLE), those OID values end up as JSON numbers. That's good! In contrast, serializing OIDs to JSON within PostgreSQL requires us to manually cast them to bigint, making the RETURN jsonb pattern more prone to developer error, as in this bug.

@kgodey kgodey added this to the Pre-beta test build #1 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement constraints RPC methods
4 participants