-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement explorations.run
RPC endpoint
#3696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, things look good and I like the methodology. I did request a change which should be pretty simple for the API-facing function signature. The reason is that I'd like to align this with the records.list
call style when it's easy, and that seems like low-hanging fruit.
I do think that we should make the documentation for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Fixes #3715
Important
Some notable changes to the request object.
base_table
->base_table_oid
id
->attnum
jp_path
->join_path
join_path
should be an ordered list of in the form [[left_table_oid, attnum], [right_table_oid, attnum]]Request
Response
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin