-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Records grouping #3721
Records grouping #3721
Conversation
@Anish9901 This can be reviewed, I've just marked it as a draft since it depends on #3708, and should not be merged until after that one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @mathemancer, I've requested some minor changes after which this can be merged.
@mathemancer we should probabaly also metion somewhere that ordering is nessasary for grouping to work as intended. |
Co-authored-by: Anish Umale <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review comment so my pending comments will show 💩 💩
I'm not sure. The REST API works the same way, and (in my mind) these operations should be thought of separately. There are other possible UIs that would (for example) just annotate each row with its group ID and/or count. |
Related to #3690
Adds a number of SQL functions that produce groupings of records when required. The grouping object submitted should have the keys
columns
and (optionally)preproc
.The resulting
grouping
object will have the keyscolumns
,preproc
, andgroups
.The values associated with each of these keys are the same as in the REST API.
Technical details
The new functionality is documented, and if the documentation is insufficient to understand how this works, or the needed request format, please request an improvement.
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin