Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add records.add RPC function #3745

Merged
merged 10 commits into from
Aug 13, 2024
Merged

Add records.add RPC function #3745

merged 10 commits into from
Aug 13, 2024

Conversation

mathemancer
Copy link
Contributor

Fixes #3738

Adds a records.add function to the RPC endpoint.

Technical details

The function is documented, and its use should be clear. However, note that the response no longer includes count or grouping, in contrast with the REST endpoint. This change of behavior was validated with the FE team.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@mathemancer mathemancer requested a review from Anish9901 August 8, 2024 08:47
@mathemancer mathemancer added the pr-status: review A PR awaiting review label Aug 8, 2024
@mathemancer mathemancer added this to the Beta milestone Aug 8, 2024
@mathemancer mathemancer mentioned this pull request Aug 9, 2024
7 tasks
Comment on lines 163 to 166
count: int
results: list[dict]
grouping: GroupingResponse
preview_data: list[dict]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathemancer can you please update these to match the response from add_record_to_table and then merge this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@mathemancer mathemancer enabled auto-merge August 13, 2024 04:22
@mathemancer mathemancer added this pull request to the merge queue Aug 13, 2024
Merged via the queue into develop with commit 684f871 Aug 13, 2024
37 checks passed
@mathemancer mathemancer deleted the records_add branch August 13, 2024 04:50
@kgodey kgodey modified the milestones: Beta, Pre-beta test build #1 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement records.add RPC method
3 participants