Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement database_privileges.get_owner_oid_and_curr_role_db_priv RPC endpoint #3760

Merged
merged 4 commits into from
Aug 17, 2024

Conversation

Anish9901
Copy link
Member

Fixes #3735

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Anish9901
Copy link
Member Author

@pavish can you tell me why do we need owner_oid in the response and how are we going to use it?

@pavish
Copy link
Member

pavish commented Aug 15, 2024

@Anish9901 The owner information is displayed on the UI when checking/modifying permissions and transferring ownership. It is also needed to check if certain functionalities are supported such as dropping the object.

The information of the owner i.e. owner_oid and the current role's access permissions are needed at every level, database, schema, and tables. In schema and tables, these can be in the response in the list endpoint. For databases, we would require connecting to each db to query it inorder to make it a part of the list endpoint. Inorder to avoid that, I added a different endpoint called get_basic. I've mentioned this as a comment on a comment in the issue.

I assume you would like to rename it to get_curr_role_priv and trying to avoid owner_oid there. I would suggest against it and either prefer get_basic as the name or something else that denotes that the endpoint also contains the owner information.

db/sql/00_msar.sql Outdated Show resolved Hide resolved
@Anish9901 Anish9901 changed the title Implement database_privileges.get_curr_role_priv RPC endpoint Implement database_privileges.get_owner_oid_and_curr_role_db_priv RPC endpoint Aug 15, 2024
Copy link
Contributor

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine. Once @pavish is happy, I'm happy.

Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@pavish pavish added this pull request to the merge queue Aug 17, 2024
Merged via the queue into develop with commit 4ab8ba0 Aug 17, 2024
39 checks passed
@pavish pavish deleted the get_basic branch August 17, 2024 20:15
@kgodey kgodey added this to the Pre-beta test build #1 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

databases_privileges.get_basic
4 participants