Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB page - role configuration, collaborators, roles #3762

Merged
merged 41 commits into from
Aug 22, 2024
Merged

DB page - role configuration, collaborators, roles #3762

merged 41 commits into from
Aug 22, 2024

Conversation

pavish
Copy link
Member

@pavish pavish commented Aug 18, 2024

Implements the Settings tab within the Database page

Under the hood, it implements the base for the new store structures and the required model classes. It does not replace existing stores.

The PR focuses on getting all functionality working and does not accurately follow the layout and colors from the figma design. This was discussed and approved in the design meetings.

The Roles page actions throw an error from the server since the RPC functions are not yet implemented on the backend.

Screenshots

  • Screenshot 2024-08-22 at 8 08 47 PM
  • Screenshot 2024-08-22 at 8 08 59 PM
  • Screenshot 2024-08-22 at 8 09 07 PM
  • Screenshot 2024-08-22 at 8 09 56 PM
  • Screenshot 2024-08-22 at 8 10 07 PM
  • Screenshot 2024-08-22 at 8 10 14 PM
  • Screenshot 2024-08-22 at 8 10 28 PM

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

pavish added 30 commits August 12, 2024 23:12
@pavish pavish marked this pull request as ready for review August 22, 2024 14:44
@pavish
Copy link
Member Author

pavish commented Aug 22, 2024

I'm going to be merging this without review once the workflows pass since @seancolsen is off. This was discussed with Sean. The changes would be reviewed retroactively once he's back.

@pavish pavish enabled auto-merge August 22, 2024 14:49
@pavish pavish added this pull request to the merge queue Aug 22, 2024
Merged via the queue into develop with commit 02f0509 Aug 22, 2024
38 checks passed
@pavish pavish deleted the db-page-1 branch August 22, 2024 15:10
@kgodey kgodey added this to the Pre-beta test build #1 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants